This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Add valgrind support to alloc-pool.c
On 12/4/06, Kenneth Zadeck <zadeck@naturalbridge.com> wrote:
Daniel Berlin wrote:
> Looks right to me, but why not submit it for mainline instead, and
> bring it in during a merge?
> You really shouldn't merge things like this to dataflow when they
> could just go on mainline (the debug counters is another example).
>
I did not realize that doing that was a problem. I have it in my stuff
that I am working on, so I was just going to let andrew check it in so
that it was not part of my next patch. I figured it might take a while
to get someone to review it for mainline.
It just makes your eventual merge into mainline harder later, and/or
we end up with stuff "left behind" on branches because people forget
it was there :).
My suggestion: Submit it for mainline, wait a week or so, and if
nobody approves it, then keep it on dataflow until approved.
--Dan