This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: reorganise SPU crt0 files
- From: Andrew_Pinski at PlayStation dot Sony dot Com
- To: Ben Elliston <bje at au1 dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, pinskia at physics dot uc dot edu, Sa Liu <saliu at de dot ibm dot com>
- Date: Thu, 30 Nov 2006 17:03:31 -0800
- Subject: Re: PATCH: reorganise SPU crt0 files
pinskia@physics.uc.edu wrote on 11/30/2006 04:32:48 PM:
> The following patch, written by Sa Liu (Cc'ed), reorganises the C
> runtime files to move much of the code to libgloss. I will be
> submitting the corresponding patch to libgloss shortly and will not
> commit either patch until they are approved by both projects to
> minimise bother. :-)
>
> Okay for the trunk? [I've just noticed that we need to update the
> documentation, so I will work on that now while this patch is being
> reviewed.]
I don't see a need for the follow part of the patch:
+#undef INIT_SECTION_ASM_OP
+#define INIT_SECTION_ASM_OP "\t.section\t\".init\""
+#undef FINI_SECTION_ASM_OP
+#define FINI_SECTION_ASM_OP "\t.section\t\".fini\""
as INIT_SECTION_ASM_OP/FINI_SECTION_ASM_OP are defined in config/elfos.h:
/* On svr4, we *do* have support for the .init and .fini sections, and we
can put stuff in there to be executed before and after `main'. We let
crtstuff.c and other files know this by defining the following symbols.
The definitions say how to change sections to the .init and .fini
sections. This is the same for all known svr4 assemblers. */
#define INIT_SECTION_ASM_OP "\t.section\t.init"
#define FINI_SECTION_ASM_OP "\t.section\t.fini"
The patch is ok if you remove those two defines.
Thanks,
Andrew Pinski