This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Remove useless loop from alias.c
- From: "Daniel Berlin" <dberlin at dberlin dot org>
- To: "Steven Bosscher" <stevenb dot gcc at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 27 Nov 2006 09:05:50 -0500
- Subject: Re: [PATCH] Remove useless loop from alias.c
- References: <firstname.lastname@example.org>
On 11/25/06, Steven Bosscher <email@example.com> wrote:
This patch removes an expensive loop in alias.c:init_alias_analysis.
The comment before the loop already says it:
- This loop may not be needed any longer now that the main loop does
- a better job at propagating alias information. */
Well, it's not needed as far as I can tell. I've counted the number
of passes in this loop for ~600 preprocessed C and C++ files from GCC
itself, and there was *never* more than one pass, i.e. nothing changed
in the loop So even if this is still a useful loop, it's questionable
whether the cost/benefit ratio justifies keeping the loop.
This is good enough numbers for me :)
The patch is okay, thanks!