This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Small cleanups to cse.c
On 11/25/06, Eric Botcazou <firstname.lastname@example.org> wrote:
> Actually, that looks like a mistake. I should have typed
> if (!any_condjump_p (insn))
> gcc_unreachable ();
> there, without the ENABLE_CHECKING.
Not the correct idiom either. :-)
Well, not incorrect, just different. You'll find the form I suggested
in a lot of places in GCC as well.
You probably simply want:
gcc_assert (any_condjump_p (insn));
This would also work, but in this form we wouldn't check that insn has
the valid form if gcc is configured with assert checking disabled.
I prefer to err on the safe side and check this even with assert
checking disabled ;-) But I don't feel strongly about it and I can go
with your suggestion if that's what most other folks prefer.