This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bootstrap (PR rtl-opt/29879)

Andrew MacLeod wrote on 11/20/06 15:47:

I think a even a single day is enough. If I post a patch one day and
don't commit it until the next (or even later that day), I always either
do an update or fresh checkout/apply patch and build/make check to
ensure nothing has interacted with what I am applying. Good lord, I
think it is simply appalling to check in patches which are 2 weeks old
without testing them again.

For major check-ins, I usually do a fresh checkout and build/test cycle
afterwards to make sure nothing broke. (or make sure I didn't forget to
checkin a file, etc)

You cant reasonably remove the couple of hours window between applying
and building/testing/checking in, but it at least vastly improves the
chances of not causing problems. The person doing the check-in should
exercise due diligence to ensure they didn't introduce anything

Agreed. We don't need special rules here. This is just common sense. Checking in a major patch that is more than a few hours old without doing another full bootstrap/test cycle is simply not acceptable.

And if the bootstrap/test cycle takes a long time, then the committer should be available to help with any breakages that popped up.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]