This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran,patch] Add ISO_FORTRAN_ENV module
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: FX Coudert <fxcoudert at gmail dot com>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 19 Nov 2006 12:45:30 -0800
- Subject: Re: [gfortran,patch] Add ISO_FORTRAN_ENV module
- References: <2C875733-99E1-4E44-BAC6-701E7E9C7325@gmail.com>
On Sat, Nov 18, 2006 at 02:59:41PM +0100, FX Coudert wrote:
> Hi all,
>
> Attached is the last version of my ISO_FORTRAN_ENV patch, now that
> the intrinsic/non-intrinsic modules patch has been commited. I
> modified the code to correct the glitches detected by Tobias Burnus.
>
> Bootstrapped (on top of mainline rev. 118930, because later ones fail
> due to PR 29879) and regtested on i686-linux. OK for mainline?
>
The patch is ok if you address Brooks and Tobias comments.
One other item. Do you need to use uppercase names for
the symbols (e.g., "IOSTAT_END" instead of "iostat_end")?
I know that gfortran translates lowercase to upper as it
parses a file. I tried tracing through the code to see
when/if uppercase is needed.
--
Steve