Re: [C/C++ PATCH] Reorganize c-common.c's convert_and_check

["Manuel LÃpez-IbÃÃez" <lopezibanez at gmail dot com>]

On 16/11/06, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Thu, 16 Nov 2006, Manuel Lopez-Ibanez wrote:
>
> > Hi Roger,
> >
> > I am trying to integrate your patch with my patch at
> > http://gcc.gnu.org/ml/gcc-patches/2006-11/msg00248.html to avoid
> > conflicts.
>
> I'd rather not rereview the same patch with a second patch integrated into
> it, and a union of your patch with Roger's would violate the principle of
> patches being minimal indivisible units.  I approved your patch as is with
> the expectation that it would be applied as is.  Once you have committed
> it to mainline, and once a new version of Roger's patch updated to apply
> to mainline with your patch applied has been posted, I can then review the
> new version of Roger's patch (having approved your patch, there's no point
> in reviewing the old version).

That seems sensible to me.  Then, is Roger's patch the one that must
be updated?

Nevertheless, since I have already started to integrate Roger's
changes and I was also going to submit a patch to remove
unsigned_conversion_warning(), would you (Roger and Joseph) mind if I
am the one who updates Roger's patch so it applies cleanly after my
previous patch ?

Cheers,

Manuel.