This is the mail archive of the
mailing list for the GCC project.
Re: PATCH: PR middle-end/29862: Calling a function with gcc_assert
- From: "Kaveh R. GHAZI" <ghazi at caip dot rutgers dot edu>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 15 Nov 2006 22:11:10 -0500 (EST)
- Subject: Re: PATCH: PR middle-end/29862: Calling a function with gcc_assert
- References: <20061116021256.GA28257@lucon.org>
On Wed, 15 Nov 2006, H. J. Lu wrote:
> We shouldn't call mpfr_set_str with gcc_assert since it leads to
> mpfr_set_str is only called when runtime check is enabled. This
> patch fixes it.
Actually that's not true. The definition of gcc_assert evaluates the
argument >even when assert checking is turned off<. Look at the
definition in system.h.
However if you feel the code as I wrote it is misleading to the average
person, I have no objection to your change.
Kaveh R. Ghazi firstname.lastname@example.org