This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR c++/29475: Incomplete template diagnostics

Simon Martin wrote:
> Hello Mark.
> Thanks a lot for your feedback.
> On Sunday 12 November 2006 20:08, Mark Mitchell wrote:
>> [...]
>> Would you care to take on that change as well?  If not, you could add 
>> the extra parameter to perform_or_defer_access_check, but just store
>> decl, rather than diagnostic_decl.  That will not fix the full problem,
>> but it will fix some of the cases, and it moves us in the right direction.
> I am willing to try to change the "storage" of the deferred checks from a 


> That's the reason why submit the following patch, that "implements" the 
> partial solution that you proposed, i.e. adds an extra argument to 
> perform_or_defer_access_checks, the declaration to use when printing the 
> error message, which is used when the access checks are not deferred, and 
> discarded otherwise. It fixes the test case in this PR, but not the whole 
> problem. I've successfully regtested it on i686-pc-linux-gnu.

This patch is OK, thanks.

Mark Mitchell
(650) 331-3385 x713

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]