This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH, gomp]: Reject negative values for env variables
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Henderson <rth at redhat dot com>, Uros Bizjak <ubizjak at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 9 Nov 2006 13:09:24 -0500
- Subject: Re: [PATCH, gomp]: Reject negative values for env variables
- References: <email@example.com> <20061026115330.GX1785@devserv.devel.redhat.com> <firstname.lastname@example.org> <20061109180156.GA14745@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Nov 09, 2006 at 10:01:56AM -0800, Richard Henderson wrote:
> On Thu, Oct 26, 2006 at 02:37:35PM +0200, Uros Bizjak wrote:
> > >+ if (errno || (signed long) value < 0)
> I guess this patch is ok.
> I don't really see that the schedule instance needs anything
> but the errno check; setting the chunk size to 0x80000000 is
> legal, though in practice useless.
GOMP_loop_runtime_start etc. pass gomp_run_sched_chunk
(unsigned long) to gomp_loop_static_start etc. (but there
the argument is signed long, ws->chunk_size is signed long too
). As the signed vs. unsigned long is part of the ABI (GCC generated
calls store signed long values), I think we can't easily change that.