This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR22372

> Since we are back in stage 1, could you remove all the forward
> declarations for static functions?  As a separate patch, because you'll
> be forced to also re-arrange the function bodies and that makes for a
> fairly big patch.
> >
> Use void_type_node for assignment statements.

I was going to do these cleanups for all the vectorizer files separately,
after the two large pending vectorizer projects from 4.2 are in mainline
(to reduce conflicts). The one (multiple data-types) was committed
yesterday, and the second (strided accesses) will probably be committed
next week. Right after that I'll go ahead and clean up the above + the
other things you pointed out in your previous reviews:

> +   /** Transform.  **/
> +
Use /* */

> +   if (!vec_stmt) /* transformation not required.  */
> +     {
Comment inside the if().

> +       /* Arguments are ready. Create the new vector stmt.  We are
> +          two vector defs because the widened result does not fit in one
> +          The vectorized stmt can be expressed as a call to a taregt
> +          or a using a tree-code.
> +        */
Closing comment should be '.  */'

(6) add missing documentation in c-tree.texi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]