This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Fix PR29201 - [4.2 Regression] ICE in create_recovery_block, at haifa-sched.c:3692 at -O3
- From: Ian Lance Taylor <iant at google dot com>
- To: Maxim Kuvyrkov <mkuvyrkov at ispras dot ru>
- Cc: Vladimir Makarov <vmakarov at redhat dot com>, gcc-patches at gcc dot gnu dot org, fang at csl dot cornell dot edu
- Date: 07 Nov 2006 18:03:46 -0800
- Subject: Re: [PATCH]: Fix PR29201 - [4.2 Regression] ICE in create_recovery_block, at haifa-sched.c:3692 at -O3
- References: <4520109E.3090800@ispras.ru> <m3u02l1kvc.fsf@localhost.localdomain> <4522980B.1060601@ispras.ru> <m3u02l5myh.fsf@dhcp-172-18-118-195.corp.google.com> <4522A3FA.8060206@ispras.ru> <m3lknx5lal.fsf@dhcp-172-18-118-195.corp.google.com> <452FF77C.2040708@ispras.ru> <m364ekkw7k.fsf@localhost.localdomain> <4535330E.2060807@ispras.ru>
Maxim Kuvyrkov <mkuvyrkov@ispras.ru> writes:
> Ian Lance Taylor wrote:
> > Maxim Kuvyrkov <mkuvyrkov@ispras.ru> writes:
> >
> >> Here are two patches which do the same thing in a slightly different
> >> way. Pick your choice and, please, comment.
> >
> > I like your second version better.
> >
> > I think it would be better still if you pulled
> >
> >> + barrier = next_nonnote_insn (BB_END (before_recovery));
> >> + if (LABEL_P (barrier) && JUMP_TABLE_DATA_P (NEXT_INSN (barrier)))
> >> + barrier = NEXT_INSN (NEXT_INSN (barrier));
> >
> > into a small function in cfgrtl.c.
>
> Like this one?
This is OK, assuming it passes bootstrap and testing. And it needs a
ChangeLog entry.
Thanks, and thanks for your patience.
Ian