This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] New port of Cell SPU

On Fri, Nov 03, 2006 at 03:10:15PM -0800, wrote:
> The attached patch contains a port for the Cell SPU.

+(define_predicate "spu_reg_operand"
+  (and (match_operand 0 "register_operand")
+       (match_test "GET_CODE (op) != SUBREG || valid_subreg (op)")))

   Shouldn't this be written something like

(define_predicate "spu_reg_operand"
  (and (match_operand 0 "register_operand")
       (ior (not (match_code "subreg"))
	    (match_test "valid_subreg (op)"))))

? From the manual:

	"The program genrecog scans define_predicate and
	 define_special_predicate expressions to determine which RTX codes
	 are possibly allowed. You should always make this explicit in the
	 RTL predicate expression, using MATCH_OPERAND and MATCH_CODE."

+(define_predicate "spu_nonimm_operand"
+(define_predicate "spu_nonmem_operand"


+++ gcc/config/spu/t-spu-elf	(.../branches/spu-patch/gcc)	(revision 635)
+# Suppress building libgcc1.a, since the MIPS compiler port is complete
+# and does not need anything from libgcc1.a.

   Weed out MIPS references.

Rask Ingemann Lambertsen

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]