This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch,committed] Fix MIPS bootstrap breakage...


Richard Sandiford <richard@codesourcery.com> writes:
> David Daney <ddaney@avtrex.com> writes:
>> A stray comma seems to have crept into config/mips/linux.h
>>
>> Removing it allows the bootstrap to progress.
>>
>> Committed as obvious.
>>
>> David Daney
>>
>> 2006-10-30  David Daney  <ddaney@avtrex.com>
>>
>>         * config/mips/linux.h (NO_SHARED_SPECS): Correct syntax error.
>
> If you do this, you also need to add a comma to the use in linux64.h.
> Please do so, as otherwise this is a regression for mips64-linux-gnu.

As said later, there's no real mileage in using commas in linux64.h.
The idea was to have one spec per option, so that later specs can
feed off earlier options if necessary, but that clearly isn't needed
by the current linux64.h specs.  I therefore committed the following
patch after testing on mips64-linux-gnu.

(In case anyone's wondering how much my "tested on ..." claims mean
given David's bootstrap reports: I mean cross-tested.  A native
bootstrap & regression test is really slow on my h/w -- especially
when testing all 3 ABIs -- and I think cross-testing is the common
case for most MIPS users anyway.)

Richard


gcc/
	* config/mips/linux64.h (DRIVER_SELF_SPECS): Use a single spec,
	but with each set of options separated by spaces.

Index: gcc/config/mips/linux64.h
===================================================================
--- gcc/config/mips/linux64.h	(revision 118179)
+++ gcc/config/mips/linux64.h	(working copy)
@@ -24,8 +24,8 @@ the Free Software Foundation; either ver
 #undef DRIVER_SELF_SPECS
 #define DRIVER_SELF_SPECS \
 NO_SHARED_SPECS \
-"%{!EB:%{!EL:%(endian_spec)}}", \
-"%{!mabi=*: -mabi=n32}"
+" %{!EB:%{!EL:%(endian_spec)}}" \
+" %{!mabi=*: -mabi=n32}"
 
 #undef SUBTARGET_ASM_SPEC
 #define SUBTARGET_ASM_SPEC "\


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]