Re: [PATCH] Dump info for variable expansion

[Steven Bosscher <stevenb dot gcc at gmail dot com>]

On Tuesday 10 October 2006 12:58, Revital1 Eres wrote:
> :ADDPATCH middle-end (variable expansion in rtl loop-unroll):
>
> Hello,
>
> The attached patch adds dump info
> when an accumulator is expanded in the rtl loop optimizer.
> I also added a testcase for it.
>
> O.K. for mainline?

Not OK, the formatting is wrong.  You did:

+  if (dump_file){
+    fprintf (dump_file,
+    "\n;; Expanding Accumulator ");
+    print_rtl (dump_file, dest);
+    fprintf (dump_file, "\n");
+  }

but it should be:

+  if (dump_file)
+    {
+      fprintf (dump_file,
+ 		"\n;; Expanding Accumulator ");
+      print_rtl (dump_file, dest);
+      fprintf (dump_file, "\n");
+    }

which you could have known because this isn't your first patch
submission.

Otherwise it looks obvious to me.

Gr.
Steven