This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch/libiberty]: Silence -Wc++-compat warnings on mingw32
- From: Ian Lance Taylor <iant at google dot com>
- To: Danny Smith <dannysmith at clear dot net dot nz>
- Cc: GCC-patches <gcc-patches at gcc dot gnu dot org>
- Date: 25 Oct 2006 17:42:58 -0700
- Subject: Re: [Patch/libiberty]: Silence -Wc++-compat warnings on mingw32
- References: <000001c6f7dc$33bf5200$e84861cb@anykey>
Danny Smith <dannysmith@clear.net.nz> writes:
> 2006-10-25 Danny Smith <dannysmith@users.sourceforge.net>
>
> pex-win32.c (argv_to_cmdline): Replace xmalloc with XNEWVEC.
> (find_executable): Likewise.
> (win32_spawn): Cast alloca return to (char**).
> Replace malloc with XNEWVEC.
> bcopy.c (bcopy}: Add explict casts in assignments.
> - env_copy = alloca (sizeof (char *) * env_size);
> + env_copy = (char **) alloca (sizeof (char **) * env_size);
You still want sizeof (char *) in the argument to alloca, not sizeof
(char **).
This patch is OK for mainline with that change.
Thanks.
Ian