This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH](ping) Fix PR15911, VRP for && and ||

From: Diego Novillo <dnovillo at redhat dot com>
To: Richard Guenther <rguenther at suse dot de>
Cc: gcc-patches at gcc dot gnu dot org
Date: Sun, 22 Oct 2006 15:46:04 -0400
Subject: Re: [PATCH](ping) Fix PR15911, VRP for && and ||
References: <Pine.LNX.4.64.0610221553470.8942@zhemvz.fhfr.qr>

Richard Guenther wrote on 10/22/06 09:57:

2006-04-25  Jeff Law  <law@redhat.com>
	Richard Guenther  <rguenther@suse.de>

	PR tree-optimization/15911
	* tree-vrp.c (extract_code_and_val_from_cond): New function.
	(register_edge_assert_for_1): Likewise.
	(register_edge_assert_for): Handle &&/&/||/| in conditionals.
	(find_conditional_asserts): Adjust for new function signature.
	(find_assert_locations): Likewise.

Has this changed since May?

+       /* We cannot handle float types at all and will ICE in
+ 	 various ways down from compare_values.  */

> May be not. This comment still needs fixing. s/We cannot/VRP does not/ Not handling float types is done on purpose.

If nothing else changed, OK with that fix.

Follow-Ups:
- Re: [PATCH](ping) Fix PR15911, VRP for && and ||
  - From: Richard Guenther

References:
- [PATCH](ping) Fix PR15911, VRP for && and ||
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]