This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR c++/26884


Mark Mitchell wrote:
Mark Shinwell wrote:

2006-10-06 Mark Shinwell <shinwell@codesourcery.com>

PR c++/26884
* cp/typeck2.c (digest_init): Raise error upon attempts to
initialize arrays with variables.
Index: gcc/cp/typeck2.c
===================================================================
--- gcc/cp/typeck2.c (revision 117455)
+++ gcc/cp/typeck2.c (working copy)
@@ -733,6 +733,14 @@ digest_init (tree type, tree init)


return error_mark_node;
}
+
+ if (TREE_CODE (type) == ARRAY_TYPE
+ && (TREE_CODE (init) == VAR_DECL || TREE_CODE (init) == PARM_DECL))
+ {
+ error ("cannot initialize array with a variable");
+ return error_mark_node;
+ }
+

I think:


array must be initialized with brace-enclosed initializer

would be better. I also suspect that there are cases you will miss, like:

int b[2] = x->a;

That's neither a VAR_DECL or a PARM_DECL. What happens if you issue the error whenever INIT is not a CONSTRUCTOR? (The representation for a brace-enclosed initializer?)

That seems to be fine, and causes no regressions on i686-pc-linux-gnu. OK to apply to mainline? (ChangeLog entry as above.)

Mark

--


Index: gcc/cp/typeck2.c =================================================================== --- gcc/cp/typeck2.c (revision 117455) +++ gcc/cp/typeck2.c (working copy) @@ -733,6 +733,13 @@ digest_init (tree type, tree init)

          return error_mark_node;
        }
+
+      if (TREE_CODE (type) == ARRAY_TYPE && TREE_CODE (init) != CONSTRUCTOR)
+       {
+         error ("array must be initialized with a brace-enclosed initializer");
+         return error_mark_node;
+       }
+
       return convert_for_initialization (NULL_TREE, type, init,
                                         LOOKUP_NORMAL | LOOKUP_ONLYCONVERTING,
                                         "initialization", NULL_TREE, 0);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]