This is the mail archive of the
mailing list for the GCC project.
Re: Fix PR rtl-optimization/28096
- From: Eric Botcazou <ebotcazou at libertysurf dot fr>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 30 Sep 2006 18:59:08 +0200
- Subject: Re: Fix PR rtl-optimization/28096
- References: <Pine.LNX.email@example.com>
> I appreciate that this clean up is the minimal change to be consistent
> with the rest of the function, but statistically the lower case "false"
> is more prevalent in GCC's source code.
> "return false;" 1514 occurences
> "return FALSE;" 147 occurences
Right, same for its brother:
"return true;" 1017 occurences
"return TRUE;" 39 occurences
I must admit I didn't consider that for my change; a single "false" among a
bunch of "FALSE" was quite glaring and this was only a fix.
> So whilst I fully agree with your change during stage 3, we should
> probably plan a Kazu-style clean-up of the tree once we return to
> stage 1, when we have the freedom to enforce global consistency rather
> than local (function-wide) consistency. I suspect this is already part
> of the ongoing transition from "int" to "bool" for Boolean types.