This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix PR rtl-optimization/28096


Hi Roger,

> I appreciate that this clean up is the minimal change to be consistent
> with the rest of the function, but statistically the lower case "false"
> is more prevalent in GCC's source code.
>
> 	"return false;"		1514 occurences
> 	"return FALSE;"		 147 occurences

Right, same for its brother:

	"return true;"		1017 occurences
        "return TRUE;"		  39 occurences

I must admit I didn't consider that for my change; a single "false" among a 
bunch of "FALSE" was quite glaring and this was only a fix.

> So whilst I fully agree with your change during stage 3, we should
> probably plan a Kazu-style clean-up of the tree once we return to
> stage 1, when we have the freedom to enforce global consistency rather
> than local (function-wide) consistency.  I suspect this is already part
> of the ongoing transition from "int" to "bool" for Boolean types.

Agreed.

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]