This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH]: add tests for pthread initialization macros
> > Kaveh R. Ghazi wrote:
> > > * gcc.dg/pthread-init-1.c: Define _GNU_SOURCE.
> > > * gdd.dg/pthread-init-2.c: Likewise.
> > > * gcc-dg/pthread-init-common.h: Add tests for
> > > PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP,
> > > PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP,
> > > PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP and
> > > PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP mutex
> > > * initializers.
> > > Uros.
> > Thanks for the patch. My only suggestion would be that _GNU_SOURCE
> > should be defined once in pthread-init-common.h rather than repeated
> > in every .c file. (There may be even more .c files someday so let's
> > avoid the duplication now.)
> Thanks for the review! Is the patch OK for mainline with this change?
We're pretty liberal with testcase checkins and I think this qualifies
under the "obvious" rule.
However, I would wait until your "fixes" for these macros are
installed before updating the testsuite. That's what I did.
After that, yes please install this one.
Kaveh R. Ghazi firstname.lastname@example.org