This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GCC PATCH]: add tests for pthread initialization macros


Hi Uros,

Looking pretty good, but still a couple of comments:

* I have some GNU C library headers that these sed commands
 would not alter because the initializers are correct.  Please add
 a select clause (or replace the one you have) that will fire only if
 there is work to do.  (or, at least, there is likely to be work to do.
 e.g.:
    select = '0, *\}';

* When posting a patch, I think we can leave out the changes
 to fixincl.x.  It gets generated fairly reliably.  :)

Thanks - Bruce


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]