This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Avoid multiple symbols from locale_charset (revised)


On Sep 24, 2006, at 8:20 AM, Jack Howarth wrote:
The following patch implements Bruno Haible's <bruno@clisp.org>
recommendation on how to properly eliminate the duplicate
symbols for locale_charset on Darwin...

If you really want to get rid of the warning, IMO the way to go is to
rename locale_charset to gcc_locale_charset in all files (at least
dcigettext.c and localcharset.c, maybe more).

The libintl 0.12.1 we have has local_charset used in the following files but not dcigettext.c. This patch has been tested on powerpc-apple-darwin8 without regressions. Okay for trunk. Jack

2006-09-23 Jack Howarth <howarth@bromo.med.uc.edu>

        * intl/localecharset.c (get_charset_aliases)
        Rename locale_charset as gcc_locale_charset.
	* intl/localcharset.h Likewise.
	* intl/localename.c Likewise.
	* intl/loadmsgcat.c Likewise.

I'm fine with this, though, I'm not a maintainer for this code.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]