This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch ping] PR26792: use _Unwind_GetIP when HAVE_GETIPINFO not defined


>>>>> "Jack" == Jack Howarth <howarth@bromo.msbb.uc.edu> writes:

Jack>      Can I get a review of this patch which is the first
Jack> of two parts which finally fix PR26792? This will eliminate
Jack> a P1 PR. Thanks in advance.
Jack> http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00906.html

I took another look at this while preparing to check it in.
exception.cc now reads:

  int ip_before_insn = 0;
[...]
#ifdef HAVE_GETIPINFO
  ip = _Unwind_GetIPInfo (context, &ip_before_insn);
#else
  ip = _Unwind_GetIP (context) - 1;
#endif
  if (! ip_before_insn)
    --ip;

I notice that in the !HAVE_GETIPINFO case, we subtract 2 from the
result of _Unwind_GetIP.  Is that intentional?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]