Re: [lto] PATCH: add varargs support to DWARF reader

[Mark Mitchell <mark at codesourcery dot com>]

Sandra Loosemore wrote:
> Mark Mitchell wrote:
>
> > Is there a reason not to just return void_type_node directly from 
> > lto_read_unspecified_parameters_DIE?  I believe that DWARF doesn't 
> > have a "void" type (using a null type pointer to indicate void in 
> > things like "void *") and, in any case, "void" is certainly not a 
> > valid parameter type.  So, at the risk of being a bit cute, you could 
> > probably just return void_type_node directly, bypassing the cookie.
>
> I did consider that, but decided that it was more robust and less 
> confusing to use the cookie than rely on punning some other object with 
> something other than its normal meaning.  (Not that GCC isn't already 
> full of that sort of stuff, but I don't need to add to it....)

Good enough.

Thanks,

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713