This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix PR28516 (Arm nested function ICE)


> > +     else if (GET_CODE (e1) == PLUS
> > +	      && GET_CODE (XEXP (e1, 0)) == REG
> > +	      && REGNO (XEXP (e1, 0)) == SP_REGNUM
> > +	      && GET_CODE (XEXP (e1, 1)) == CONST_INT)
> > +	{
> > +	  /* Set reg to offset from sp.  */
> > +	  asm_fprintf (asm_out_file, "\t.movsp %r, #%d\n",
> > +		       REGNO (e0), (int)INTVAL(XEXP (e1, 1)));
> > +	}
>
> Least substantive comment of the day: I think the coding standards say
> that you should remove the braces, since you've only got a single
> dependent statement.  (The comment doesn't count.)

Hmm, I can't find anything definitive.
My personal preference is to include the braces if the block is more than one 
source line, especially when preceded by a multi-line conditional.

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]