This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto] PATCH: fill in code to merge declarations


Sandra Loosemore wrote:

Here I've cleaned up the code for merging VAR_DECLs and implemented the rules for comparing whether two types are the same, as well as filling in the FUNCTION_DECL merge function to do something useful.

Good!


else
DECL_EXTERNAL (result) = 1;
+ if (inlined == DW_INL_declared_inlined
+ || inlined == DW_INL_declared_not_inlined)
+ DECL_DECLARED_INLINE_P (result) = 1;
+

Shouldn't the second case be DW_INL_inlined? But, I think you only want the first case -- the compiler is always free to inline things anyhow, and the bit you're setting is about what the user has explicitly declared.


Otherwise, this looks OK. Actually, that's an understatement; thanks for stepping up to tackle some of these semantic issues!

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]