This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Pessimization in doloop
- From: Bernd Schmidt <bernds_cb1 at t-online dot de>
- To: Andreas Tobler <toa at pop dot agri dot ch>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 16 Sep 2006 01:34:43 +0200
- Subject: Re: Pessimization in doloop
- References: <450A8CB1.1080206@t-online.de> <450B2744.3060209@pop.agri.ch>
Andreas Tobler wrote:
this one broke bootstrap on ppc.
My apologies.
cc1: warnings being treated as errors
/Volumes/development/gcc/head/gcc/gcc/loop-doloop.c: In function
'doloop_optimize':
/Volumes/development/gcc/head/gcc/gcc/loop-doloop.c:530: warning:
comparison between signed and unsigned
/Volumes/development/gcc/head/gcc/gcc/loop-doloop.c:535: warning: too
many arguments for format
make[3]: *** [loop-doloop.o] Error 1
Argh. Bootstrapping on i686 of course generates no warnings since the
whole file is ifdeffed out.
is the attached fix ok ?
- "Doloop: number of iterations too costly to compute.\n",
+ "Doloop: number of iterations (%u)too costly to
compute.\n",
est_niter);
est_niter isn't really relevant. I've installed the following on top of
your patch.
Bernd
Index: ChangeLog
===================================================================
--- ChangeLog (revision 116983)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2005-09-16 Bernd Schmidt <bernd.schmidt@analog.com>
+
+ * loop-doloop.c (doloop_optimize): Remove bogus arg from debugging
+ printf.
+
2006-09-15 Jim Wilson <wilson@specifix.com>
* config/ia64/ia64.c (ia64_legitimate_constant_p, cast CONST):
Index: loop-doloop.c
===================================================================
--- loop-doloop.c (revision 116983)
+++ loop-doloop.c (working copy)
@@ -532,8 +532,7 @@ doloop_optimize (struct loop *loop)
{
if (dump_file)
fprintf (dump_file,
- "Doloop: number of iterations (%u) too costly to compute.\n",
- est_niter);
+ "Doloop: number of iterations too costly to compute.\n");
return false;
}