This is the mail archive of the
mailing list for the GCC project.
Re: Patch for PR28490 (IA64 symbol+offset)
- From: Steve Ellcey <sje at cup dot hp dot com>
- To: wilson at specifix dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 15 Sep 2006 14:54:19 -0700 (PDT)
- Subject: Re: Patch for PR28490 (IA64 symbol+offset)
> On Mon, 2006-09-11 at 10:08 -0700, Steve Ellcey wrote:
> > I tested this patch over the weekend and had no regressions, do you want
> > to check it in?
> I've been a bit overwhelmed here, and have gotten well behind on my gcc
> work. I'm OK with checking in my patch as a short term solution, though
> I don't like to checking in patches I haven't tested. I don't want to
> accidentally check in a typo. But it is the weekend now, almost, so I
> can do a quick perfunctory build and check it in.
> Jim Wilson, GNU Tools Support, http://www.specifix.com
I actually found I had to make one tweak to it, it worked fine on Linux
but when I tested HP-UX I had a problem with functions. In
ia64_legitimate_constant_p I changed:
if (any_offset_symbol_operand (op, GET_MODE (op)))
if (any_offset_symbol_operand (op, GET_MODE (op))
|| function_operand (op, GET_MODE (op)))
I am not sure why this only seemed to affect HP-UX but adding the
check for function_operand seemed to fix my problems.