This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR testsuite/28950


On Sat, Sep 09, 2006 at 08:24:15PM -0400, Jack Howarth wrote:
> The attached patch eliminates the false failure of the ppc-and-1.c
> testcase in gcc.target/powerpc when tested at -m64. Tested on
> powerpc-apple-darwin8. Ok for gcc trunk?
> 
> 2006-09-09  Jack Howarth  <howarth@bromo.med.uc.edu>
> 
>         PR testsuite/28950
>         * gcc.target/powerpc/ppc-and-1.c: Fix regex as Darwin
>         assembler expects GPR references to be prefixed with 'r'.

No, this will just break the test for Linux and AIX.  Put the 'r'
inside the brackets.  (I can't approve the patch though.)

> Index: gcc/testsuite/gcc.target/powerpc/ppc-and-1.c
> ===================================================================
> --- gcc/testsuite/gcc.target/powerpc/ppc-and-1.c        (revision 116801)
> +++ gcc/testsuite/gcc.target/powerpc/ppc-and-1.c        (working copy)
> @@ -1,8 +1,8 @@
>  /* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
>  /* { dg-options "-O2" } */
>  
> -/* { dg-final { scan-assembler "rlwinm \[0-9\]+,\[0-9\]+,0,0,30"  } } */
> -/* { dg-final { scan-assembler "rlwinm \[0-9\]+,\[0-9\]+,0,29,30"  } } */
> +/* { dg-final { scan-assembler "rlwinm r\[0-9\]+,r\[0-9\]+,0,0,30"  } } */
> +/* { dg-final { scan-assembler "rlwinm r\[0-9\]+,r\[0-9\]+,0,29,30"  } } */
>  /* { dg-final { scan-assembler-not "rldicr" } } */
>  
>  /* Origin:Pete Steinmetz <steinmtz@us.ibm.com> */
> 

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]