This is the mail archive of the
mailing list for the GCC project.
Re: i386 PATCH for target/13685
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: jason at redhat dot com, gcc-patches at gcc dot gnu dot org, rth at redhat dot com
- Date: Mon, 11 Sep 2006 20:14:14 -0700
- Subject: Re: i386 PATCH for target/13685
- References: <firstname.lastname@example.org>
On Mon, Sep 11, 2006 at 07:04:00PM -0700, Mark Mitchell wrote:
> Yes. Thanks,
> On Sat, Sep 09, 2006 at 12:52:41PM -0700, Mark Mitchell wrote:
> This is a backwards-compatible ABI change for any existing -Os code,
> since the stack will still be at least as aligned as expected by any
> code out there at this point.
> So, this is OK, assuming no objections from the x86 maintainers within
> 48 hours.
> I checked it into mainline now. Is that OK for 4.1?
Now -Os no longer changes ABI. Is this patch OK?
2006-09-11 H.J. Lu <email@example.com>
* config/i386/crtfastmath.c (set_fast_math): Don't force stack
--- gcc/config/i386/crtfastmath.c (revision 116487)
+++ gcc/config/i386/crtfastmath.c (revision 116430)
@@ -38,12 +38,6 @@
#define SSE (1 << 25)
static void __attribute__((constructor))
-/* The i386 ABI only requires 4-byte stack alignment, so this is necessary
- to make sure the fxsave struct gets correct alignment.
- See PR27537 and PR28621. */