This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: i386 PATCH for target/13685


On Mon, Sep 11, 2006 at 07:04:00PM -0700, Mark Mitchell wrote:
> Yes.  Thanks,
> 
> On Sat, Sep 09, 2006 at 12:52:41PM -0700, Mark Mitchell wrote:
>  
>  This is a backwards-compatible ABI change for any existing -Os code, 
>  since the stack will still be at least as aligned as expected by any 
>  code out there at this point.
>  
>  So, this is OK, assuming no objections from the x86 maintainers within 
>  48 hours.
>  
> 
> I checked it into mainline now. Is that OK for 4.1?
> 
> 

Now -Os no longer changes ABI. Is this patch OK?


H.J.
----
2006-09-11  H.J. Lu  <hongjiu.lu@intel.com>

	* config/i386/crtfastmath.c (set_fast_math): Don't force stack
	alignment.

Index: gcc/config/i386/crtfastmath.c
===================================================================
--- gcc/config/i386/crtfastmath.c	(revision 116487)
+++ gcc/config/i386/crtfastmath.c	(revision 116430)
@@ -38,12 +38,6 @@
 #define SSE	(1 << 25)
 
 static void __attribute__((constructor))
-#ifndef __x86_64__
-/* The i386 ABI only requires 4-byte stack alignment, so this is necessary
-   to make sure the fxsave struct gets correct alignment.
-   See PR27537 and PR28621.  */
-__attribute__ ((force_align_arg_pointer))
-#endif
 set_fast_math (void)
 {
 #ifndef __x86_64__


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]