This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR26983


Hi Steven,

On Sun, 10 Sep 2006, Steven Bosscher wrote:
> 	* builtins.c (expand_builtin_setjmp): Force next_lab to be
> 	preserved.
>
> 	* gcc.dg/pr26983.c: New test.

This is OK for mainline.  Thanks.  I can backport it to the release
branches for you, after a week or so on mainline without problems.

I agree completely with the instability of LABEL_NUSES, relying on
it to be accurately kept up to date has been a source of headaches.
Interestingly a quick grep of LABEL_NUSES shows that vast majority
of uses just update the field, which is only examined in a handful
of places.  Given that cse.c (one of your favorites) and flow.c are
undergoing rewrites, it might be resoanble to start removing the few
remaining uses of LABEL_NUSES (where possible) and instead using the
CFG, with an aim to deprecating it before too long.

Thanks again for fixing this.

Roger
--


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]