This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] *.exp: Robustify uses of regsub.


Kazu Hirata wrote:
Hi Mark,

Why are you using the (?b) approach with "regsub", rather than (?q)? It seems correct to me to treat $srcdir as a literal, but, with (?b) there are still (theroetically) filenames that contain syntactic meta-characters, IIUC. Am I missing something?

You are absolutely right. I should be using (?q)$srcdir/.


OK with this change?

Yes, thanks, assuming that you've tested that change.


--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]