This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, take 2] Fix PR target/28946


On Thu, Sep 07, 2006 at 10:36:03AM -0600, Roger Sayle wrote:
> 
> Hi H.J.,
> 
> On Thu, 7 Sep 2006, H. J. Lu wrote:
> > 2006-09-05  H.J. Lu  <hongjiu.lu@intel.com>
> >
> > 	* config/i386/i386.c (x86_partial_flag_reg_stall): New.
> >
> > 	* config/i386/i386.h (x86_partial_flag_reg_stall): New.
> > 	(TARGET_PARTIAL_FLAG_REG_STALL): New.
> >
> > 	* config/i386/i386.md (*ashldi3_cmp_rex64): Disabled for
> > 	TARGET_PARTIAL_FLAG_REG_STALL.
> > 	(*ashldi3_cconly_rex64): Likewise.
> > 	(*ashlsi3_cmp): Likewise.
> > 	(*ashlsi3_cconly): Likewise.
> > 	(*ashlsi3_cmp_zext): Likewise.
> > 	(*ashlhi3_cmp): Likewise.
> > 	(*ashlhi3_cconly): Likewise.
> > 	(*ashlqi3_cmp): Likewise.
> > 	(*ashlqi3_cconly): Likewise.
> > 	(*ashrdi3_cmp_rex64): Likewise.
> > 	(*ashrdi3_cconly_rex64): Likewise.
> > 	(*ashrsi3_cmp): Likewise.
> > 	(*ashrsi3_cconly): Likewise.
> > 	(*ashrsi3_cmp_zext): Likewise.
> > 	(*ashrhi3_cmp): Likewise.
> > 	(*ashrhi3_cconly): Likewise.
> > 	(*ashrqi3_cmp): Likewise.
> > 	(*ashrqi3_cconly): Likewise.
> > 	(*lshrdi3_cmp_rex64): Likewise.
> > 	(*lshrdi3_cconly_rex64): Likewise.
> > 	(*lshrsi3_cmp): Likewise.
> > 	(*lshrsi3_cconly): Likewise.
> > 	(*lshrsi3_cmp_zext): Likewise.
> > 	(*lshrhi3_cmp): Likewise.
> > 	(*lshrhi3_cconly): Likewise.
> > 	(*lshrqi2_cmp): Likewise.
> > 	(*lshrqi2_cconly): Likewise.
> 
> This is OK for mainline, on top of Uros' regression fix.  I'm not sure
> if the m_GENERIC functionality has been backported to the 4.1 or 4.0
> branches, so we can haggle over whether it's worthwhile backporting
> this revision, especially given core and core2 tuning hasn't officially
> be contributed to GCC (even to mainline) yet.
> 
> 

It will be very nice to have m_GENERIC in 4.1. The patches are at

http://gcc.gnu.org/ml/gcc-patches/2006-01/msg01436.html

They have been tested in FC5 and SLES 10.

Thanks.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]