This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] fix PR/26778 by reapplying a reverted patch

From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
To: Roger Sayle <roger at eyesopen dot com>
Cc: gcc-patches at gcc dot gnu dot org, Ulrich Weigand <uweigand at de dot ibm dot com>
Date: Thu, 07 Sep 2006 18:19:51 +0200
Subject: Re: [RFA] fix PR/26778 by reapplying a reverted patch
References: <Pine.LNX.4.44.0609070819160.28401-100000@www.eyesopen.com>

Could you also add a test to the testsuite?  Perhaps the one from the
PR by scanning for SSE registers on x86 which I believe shouldn't appear
anywhere in the assembler after this patch.

Sure.

Unless Ulrich has an objection, this is OK for mainline. Given the historical problems I think its best to let it bake for at least a week or two on mainlaine before considering backporting it (and any necessary AIX, x86 and SH changes) to the 4.0/4.1 branches to resolve this PR. It might be that the total patch set is too intrusive and we may need to close this as WONTFIX for 4.0 and maybe even 4.1.

The WONTFIX was my plan as well. Personally I won't attempt a backport.

Thanks to both you and Richard G for testing on five backends, it helps improve confidence that this is a reasonable fix in stage 3. Thanks to you and Dale for fixing this; conceptually I like this reload change a lot.

Well, luckily it's regclass. But it upset as many targets as if it was a reload or combine change. ;-)

Paolo

References:
- Re: [RFA] fix PR/26778 by reapplying a reverted patch
  - From: Roger Sayle

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]