This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR24367 S/390 pic address handling


Andreas Krebbel wrote:

> !   if (TARGET_64BIT
> !       && (SYMBOLIC_CONST (operands[1])
> ! 	  || (GET_CODE (operands[1]) == PLUS
> ! 	      && REG_P (XEXP (operands[1], 0)) 
> ! 	      && XEXP (operands[1], 0) == pic_offset_table_rtx
> ! 	      && SYMBOLIC_CONST (XEXP (operands[1], 1)))))

The REG_P test is redundant with with == pic_offset_table_rtx
check.  

Otherwise, this patch is fine.  Thanks!

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  Linux on zSeries Development
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]