This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Off-by-one errors in gcc/config/arm/pr-support.c


Richard Earnshaw wrote:

> Ok, except that your testcase should call abort() on failure (it
> currently returns 1 from main.  See other testcases in the same
> subdirectory for examples.

I'm equally happy with either convention, but is there a reason to
prefer abort?  I've preferred returning a non-zero exit status, on the
grounds that abort might cause a core dump, which might be slow.  Since
we require libgloss tricks for systems where you can't get the exit
status, I thought returning a non-zero exit status was OK.  Is that not
the case?

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]