This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix externally_visible attribute handling (PR c/28744)
- From: Jan Hubicka <jh at suse dot cz>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Jan Hubicka <jh at suse dot cz>
- Date: Thu, 17 Aug 2006 11:59:24 +0200
- Subject: Re: [PATCH] Fix externally_visible attribute handling (PR c/28744)
- References: <20060816103206.GK32572@devserv.devel.redhat.com>
> Hi!
>
> As the attached testcases show, we have been warning and ignoring
> "externally_visible" attribute on extern variable decls (but accepting
> it on extern function prototypes). This patch fixes it, on the other
> side adds the warning to cases which can't be caught already during
> parsing (e.g. GCC wasn't warning about
> static void foo (void) { }
> extern void foo (void) __attribute__((externally_visible));
> ).
> Ok for trunk?
OK, thanks!
Honza