This is the mail archive of the
mailing list for the GCC project.
Re: [gomp] Fix libgomp OMP_* env var handling
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: Diego Novillo <dnovillo at redhat dot com>, Richard Henderson <rth at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 16 Aug 2006 11:20:06 -0400
- Subject: Re: [gomp] Fix libgomp OMP_* env var handling
- References: <20060816114108.GL32572@devserv.devel.redhat.com> <firstname.lastname@example.org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Aug 16, 2006 at 08:13:42AM -0700, Andrew Pinski wrote:
> On Wed, 2006-08-16 at 07:41 -0400, Jakub Jelinek wrote:
> > The OpenMP 2.5 standard says in chapter 4 that the values of the
> > environment vars (of course unlike the variable names themselves)
> > are case insensitive and can have leading and/or trailing whitespace
> > (and in the case of OMP_SCHEDULE can have whitespace before
> > and/or after the comma).
> > The following patch fixes it, ok for trunk?
> My only problem is how portable is strncasecmp? It is a non standard
> function and IIRC we don't link libgomp against liberity either.
Non-standard? It is certainly in POSIX, BSDs, ...
And, libgfortran uses it without any configury checks, so I'd say if nobody
complained about this in libgfortran, nobody will complain about it in