This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix PR28489 - [4.2 regression] ICE in move_insn, at haifa-sched.c:1968


Maxim Kuvyrkov wrote:

Hi!

This patch fixes PR rtl-optimization/28489.

The first problem is that we create new basic block for unreachable instructions in the wrong place (in the middle of current block) - sadly, that's my typo.

The second problem is that we should skip empty blocks during EBB scheduling so that there will be no need to move jumps between blocks when that is not needed.

::ADDPATCH scheduler:

------------------------------------------------------------------------

2006-08-14 Maxim Kuvyrkov <mkuvyrkov@ispras.ru>

	PR rtl-optimization/28489
	* sched-ebb.c (begin_schedule_ready): Create basic block
	at the right place.
	(advance_target_bb): Skip empty blocks.
	* haifa-sched.c (bb_note): Make global.
	* sched-int.h (bb_note): Add prototype.

2006-08-14 Maxim Kuvyrkov <mkuvyrkov@ispras.ru>

	PR rtl-optimization/28489
	* gcc.c-torture/compile/pr28489.c: New test.




The patch is ok. You can commit it into the mainline. Only use one changelog entry please.

Vlad



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]