This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH: fix PR 28687


Benjamin Smedberg wrote:

> 2006-08-11   Benjamin Smedberg <benjamin@smedbergs.us>
> 
>     PR c++/28687
>     * doc/invoke.texi (-no-rtti): specifically document
>     dynamic_cast<void*>
> 
> cp/
> 2006-08-11   Benjamin Smedberg <benjamin@smedbergs.us>
> 
>     PR c++/28687
>     * rtti.c (build_dynamic_cast, build_dynamic_cast_1):
>     Move -fno-rtti check to be more specific
> 
> 
> testsuite/
> 2006-08-11   Benjamin Smedberg <benjamin@smedbergs.us>
> 
>     PR c++/28687
>     * g++.dg/rtti/no-rtti-voidptr.C: new

This patch is (almost) technically OK.  Do any of our local experts have
an opinion as to whether this patch is big enough to require a copyright
assignment?

> +needed. The dynamic_cast operator can still be used for casts that do not
> +require runtime type information, such as dynamic_cast<void*>.

You are missing texinfo markup here.  You should use @code{dynamic_cast}
and @code{dynamic_cast<void *>}.  Also, the second clause would be
better written as "i.e., casts to @code{void *} or to unambiguous base
classes", as those are the only two cases that are permitted.

Please make that change, verify that the generated documentation looks
correct, and resubmit your patch.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]