This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] for PR 27735
- From: Daniel Berlin <dberlin at dberlin dot org>
- To: Eric Botcazou <ebotcazou at libertysurf dot fr>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 10 Aug 2006 08:34:32 -0400
- Subject: Re: [patch] for PR 27735
- References: <20060524095159.GA14182@atrey.karlin.mff.cuni.cz> <200608101212.58767.ebotcazou@libertysurf.fr>
>
>> * gcc.dg/pr27735.c: New test.
>
> I'm from the old school so I think dg testcases should have a descriptive name
> (for example loop-unswitch-1.c), explicitly mention the PR and have a header
> acknowledging other contributions:
>
> /* PR rtl-optimization/27735 */
> /* Reported by dcb <dcb314@hotmail.com> */
> /* Testcase by Andrew Pinski <pinskia@gcc.gnu.org> */
Please don't take this the wrong way (really!), but ....
You aren't in charge of maintaining the testsuite, so i'm not sure why
you are trying to change the way it's currently being done. For
example, the only test in gcc.dg that contains information about who
reported is a single test from 2003. There are plenty of tests that are
named after the PR number.
If we (the community of gcc developers we), or the testsuite maintainer,
want to change the naming and information contained in the tests from
what is currently being done, it should be discussed, not just asserted
as the way it should be done in a patch review and required of contributors.
(I have no problem with you requesting more in the areas you maintain
after discussion if that's what the consensus is, of course)
--Dan