This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for regression PR c++/28432
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Steve Ellcey <sje at cup dot hp dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 01 Aug 2006 09:58:29 -0700
- Subject: Re: Patch for regression PR c++/28432
- References: <200608011634.JAA06481@hpsje.cup.hp.com>
Steve Ellcey wrote:
> Mark Mitchell Wrote:
>> Steve Ellcey wrote:
>>
>>> + if (!IS_AGGR_TYPE_CODE (TREE_CODE (xbasetype)))
>>> + return NULL_TREE;
>> Please use "!CLASS_TYPE_P (xbasetype)". That will cause the condition
>> to be false for pointers to member functions as well, which makes sense;
>> we should never be doing lookup on a pointer to member function.
>> However, it's just possible that we *are* doing that, out of laziness,
>> so if the patch fails any tests with that change, go with your version
>> instead.
>>
>> Patch OK with that change, or, as above, without if necessary.
>
> FYI: Using !CLASS_TYPE_P did cause quite a few testsuite failures so I
> will check this in as I originally submitted it.
OK. Thanks for trying!
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713