This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add support for html/install-html.
- From: Carlos O'Donell <carlos at codesourcery dot com>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: gcc-patches at gnu dot org, dj at redhat dot com, neroden at gcc dot gnu dot org
- Date: Wed, 26 Jul 2006 21:54:51 -0400
- Subject: Re: [PATCH] Add support for html/install-html.
- References: <20060520020138.GF31607@lios> <orhd3j40n0.fsf@free.oliva.athome.lsd.ic.unicamp.br> <20060524045630.GX31607@lios> <orlksp1mc2.fsf@free.oliva.athome.lsd.ic.unicamp.br> <20060529162706.GY26980@lios> <ormzbnfkda.fsf@free.oliva.athome.lsd.ic.unicamp.br>
On Thu, Jul 06, 2006 at 01:05:53AM -0300, Alexandre Oliva wrote:
> On May 29, 2006, "Carlos O'Donell" <carlos@codesourcery.com> wrote:
>
> > 2006-05-29 Carlos O'Donell <carlos@codesourcery.com>
>
> > * Makefile.in: Rename htmldir to gcc_htmldir.
> > Define HTMLS_BUILD, HTMLS_INSTALL, html__strip_dir,
> > html__mkdir_p. Add install-html target.
> > * configure.ac: AC_SUBST datarootdir, docdir and htmldir.
> > * configure: Regenerate.
>
> Almost ok. Just one nit:
>
> > +html__mkdir_p = mkdir -p --
>
> I don't think `mkdir -p' is kosher. Any reason to not just use
> $(mkinstalldirs)?
Patch attached, tested with an all languages build on i686-pc-linux-gnu
with no regressions.
Sorry for the delay.
OK to checkin?
Cheers,
Carlos.
--
Carlos O'Donell
CodeSourcery
carlos@codesourcery.com
(650) 331-3385 x716
2006-07-26 Carlos O'Donell <carlos@codesourcery.com>
* Makefile.in: Use mkinstalldirs.
Index: Makefile.in
===================================================================
--- Makefile.in (revision 115770)
+++ Makefile.in (working copy)
@@ -3753,17 +3753,16 @@
else true; fi;
html__strip_dir = `echo $$p | sed -e 's|^.*/||'`;
-html__mkdir_p = mkdir -p --
install-html: $(HTMLS_BUILD)
@$(NORMAL_INSTALL)
- test -z "$(htmldir)" || $(html__mkdir_p) "$(DESTDIR)$(htmldir)"
+ test -z "$(htmldir)" || $(mkinstalldirs) "$(DESTDIR)$(htmldir)"
@list='$(HTMLS_INSTALL)'; for p in $$list; do \
if test -f "$$p" || test -d "$$p"; then d=""; else d="$(srcdir)/"; fi; \
f=$(html__strip_dir) \
if test -d "$$d$$p"; then \
- echo " $(html__mkdir_p) '$(DESTDIR)$(htmldir)/$$f'"; \
- $(html__mkdir_p) "$(DESTDIR)$(htmldir)/$$f" || exit 1; \
+ echo " $(mkinstalldirs) '$(DESTDIR)$(htmldir)/$$f'"; \
+ $(mkinstalldirs) "$(DESTDIR)$(htmldir)/$$f" || exit 1; \
echo " $(INSTALL_DATA) '$$d$$p'/* '$(DESTDIR)$(htmldir)/$$f'"; \
$(INSTALL_DATA) "$$d$$p"/* "$(DESTDIR)$(htmldir)/$$f"; \
else \