This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Fwd: Question on PR25289] Latest patch attached


Ouch. See comment below.

 > Index: libgfortran/libgfortran.h
 > ===================================================================
 > *** libgfortran/libgfortran.h    (revision 115168)
 > --- libgfortran/libgfortran.h    (working copy)
 > *************** Boston, MA 02110-1301, USA.  */
 > *** 56,62 ****
 > --- 56,69 ----
 >   #if HAVE_SYS_TYPES_H
 >   #include <sys/types.h>
 >   #endif
 > +
 > + #if defined (HAVE_GFC_INTEGER_8)
 > + typedef GFC_INTEGER_8 gfc_offset;
 > + #elseif (HAVE_GFC_INTEGER_4)
 > + typedef GFC_INTEGER_4 gfc_offset;
 > + #else
 >   typedef off_t gfc_offset;
 > + #endif

In all my tests, this was defaulting to off_t because HAVE_GFC_INTEGER_8 and HAVE_GFC_INTEGER_4 are not defined yet at this point in the code. They are defined in kinds.h which is included farther down in this file. Discovered when I took the fallback condition out and I got a bootstrap failure.


So I am fixing this now and re-bootstrapping. Another good example of why reviews are so helpful.

Sorry for all the gyrations on this.

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]