This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: line insn notes cleanups (haifa-sched and modulo-sched)
- From: Mike Stump <mrs at apple dot com>
- To: Tehila Meyzels <TEHILA at il dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, stevenb dot gcc at gmail dot com, vmakarov at redhat dot com
- Date: Tue, 18 Jul 2006 15:28:48 -0700
- Subject: Re: line insn notes cleanups (haifa-sched and modulo-sched)
- References: <OF8C89DE28.8389C17D-ONC22571AF.0067D92B-C22571AF.006DB632@il.ibm.com>
On Jul 18, 2006, at 12:58 PM, Tehila Meyzels wrote:
These changes are the removal of line insn notes from haifa-sched and
modulo-sched.
- /* See sched_analyze to see how these are handled. */
+ /* See sched_analyze to see how these are handled. */
This is wrong, please omit.
- int b = BB_TO_BLOCK (bb);
+ /* int b = BB_TO_BLOCK (bb); */
Without good reason, please don't just comment out code like this.
Off-hand, I don't see a reason to preserve it.
- if (write_symbols != NO_DEBUG)
- {
- save_line_notes (b, head, tail);
- rm_line_notes (head, tail);
- }
+ /* if (write_symbols != NO_DEBUG) */
+/* { */
+/* save_line_notes (b, head, tail); */
+/* rm_line_notes (head, tail); */
+/* } */
Likewise.
- if (write_symbols != NO_DEBUG)
- {
- for (bb = 0; bb < current_nr_blocks; bb++)
- {
- rtx head, tail;
+ /* if (write_symbols != NO_DEBUG) */
+/* { */
+/* for (bb = 0; bb < current_nr_blocks; bb++) */
+/* { */
+/* rtx head, tail; */
Likewise.
- get_ebb_head_tail (EBB_FIRST_BB (bb), EBB_LAST_BB (bb), &head,
&tail);
- restore_line_notes (head, tail);
- }
- }
+/* get_ebb_head_tail (EBB_FIRST_BB (bb), EBB_LAST_BB (bb), &head,
&tail); */
+/* restore_line_notes (head, tail); */
+/* } */
+/* } */
Likewise.
- if (write_symbols != NO_DEBUG)
- rm_redundant_line_notes ();
+ /* if (write_symbols != NO_DEBUG) */
+/* rm_redundant_line_notes (); */
Likewise.