Re: Patch to fix "make proto fails"

[Andreas Jaeger <aj at suse dot de>]

I haven't seen any reply for this, so I'm resending with a fixed
subject line.

Ok to commit?

Andreas

Andreas Jaeger <aj@suse.de> writes:

> Ian Lance Taylor <iant@google.com> writes:
>
>> Andreas Jaeger <aj@suse.de> writes:
>>
>>> make proto on gcc trunk fails on Linux/x86_64 with:
>>
>> Do you actually need protoize and unprotoize?  I think it would be
>> nice to deprecate them.  Prototypes have been available for at least
>> 15 years now.
>>
>>> The trivial workaround is to add to gcc/Makefile.in something like:
>>> 
>>> # Fix for argument âclean_text_pâ might be clobbered by âlongjmpâ or âvforkâ
>>> unprotoize.o-warn = -Wno-error
>>> 
>>> If I should submit this as patch, please tell me,
>>
>> Looks good to me, not that I can approve it.
>
> It passed a complete bootstrap now, so here's a proper patch.
>
> Ok to commit?
>
> Andreas
>
> 2006-06-28  Andreas Jaeger  <aj@suse.de>
>
> 	* Makefile.in (unprotoize.o-warn): New, set to -Wno-error.
>
> Index: Makefile.in
> ===================================================================
> --- Makefile.in	(revision 115036)
> +++ Makefile.in	(working copy)
> @@ -213,6 +213,9 @@ SYSCALLS.c.X-warn = -Wno-strict-prototyp
>  # recognizing that the loop will always be executed at least once.  We need
>  # a new loop optimizer.
>  reload1.o-warn = -Wno-error
> +# Compiling unprotoize we get on x86-64 a warning about an argument
> +# clobbered by âlongjmpâ.
> +unprotoize.o-warn = -Wno-error
>  
>  # All warnings have to be shut off in stage1 if the compiler used then
>  # isn't gcc; configure determines that.  WARN_CFLAGS will be either

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj/
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature