This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto] PATCH: more CALL_EXPR-related changes


Richard Guenther wrote:

These changes are too large to be obvious really, if the branch should be merged without another review at some point.

Hmmm, Diego said the other day that it was OK. I'm working on this full-time at the moment and it would help make the best use of my time if I can get things approved and committed in a timely manner. If the size of the patches is the problem rather than their complexity, would it be better if I prepared and committed the patch for each file separately instead of bunching together each day's work? Or, I could just save up several days' worth of related work into one big patch if that would be more convenient for somebody to review all at once before I commit it? You guys tell me what procedure to use since I'm new at this. :-)


Also in your ChangeLog you should
omit the trailing gcc/ (supposed there is now a gcc/ChangeLog.lto where you
apply it to).

Well, there isn't such a thing in this branch; Kazu and Mark have been putting all their log messages in the top-level ChangeLog.lto, so I assume that's where mine go as well.


-Sandra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]