This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR28187, endless looping in VRP

Richard Guenther wrote on 07/06/06 09:08:

> While I think that doing pointer comparison in operand_equal_p to
> test for equality is useful in general, the other cases (one argument
> being NULL and the bitmap case) is a VRP speciality.
>
OK, I guess.  Let's add pointer comparison to operand_equal_p and make
the vrp versions test for non-NULL and operand_equal_p.

> Also this is only used in update_value_range and introducing vrp_operand_equal_p
> and vrp_bitmap_equal_p will make the occasional reader wonder what
> is so special about these.
> 
Let's add a comment then.  I prefer static inline functions over crowded
predicates.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]