This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add support for html/install-html.


On May 29, 2006, "Carlos O'Donell" <carlos@codesourcery.com> wrote:

> 2006-05-29  Carlos O'Donell  <carlos@codesourcery.com>

> 	* Makefile.in: Rename htmldir to gcc_htmldir.
> 	Define HTMLS_BUILD, HTMLS_INSTALL, html__strip_dir, 
> 	html__mkdir_p. Add install-html target.
> 	* configure.ac: AC_SUBST datarootdir, docdir and htmldir. 
> 	* configure: Regenerate.

Almost ok.  Just one nit:

> +html__mkdir_p = mkdir -p --

I don't think `mkdir -p' is kosher.  Any reason to not just use
$(mkinstalldirs)?

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
Secretary for FSF Latin America        http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]