This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix Tree-SRA bug with array slices

From: Eric Botcazou <ebotcazou at adacore dot com>
To: Diego Novillo <dnovillo at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 27 Jun 2006 00:51:52 +0200
Subject: Re: [PATCH] Fix Tree-SRA bug with array slices
References: <200606181441.00974.ebotcazou@adacore.com> <449FE687.3040906@redhat.com>

> OK with minor revisions below.

Thanks for the review.

> > +static struct sra_elt *
> > +next_child_for_group (struct sra_elt *child, struct sra_elt *group)
> > +{
>
> Missing function comment.

Guess what?  There was one and I removed it. :-)

> > +    case ARRAY_RANGE_REF:
> > +      /* We can't scalarize variable array indicies.  */
>
> s/indicies/indices/

This one is yours or RTH's. :-)

-- 
Eric Botcazou

References:
- [PATCH] Fix Tree-SRA bug with array slices
  - From: Eric Botcazou
- Re: [PATCH] Fix Tree-SRA bug with array slices
  - From: Diego Novillo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]